xbps-src: exit properly if mktemp(1) fails, not from its subshell.

Thanks @huglovefan
2019-06-17 17:38:07 +02:00
parent 8614cca7df
commit 7b7d7c13a1
10 changed files with 12 additions and 12 deletions
--- a/common/xbps-src/shutils/common.sh
+++ b/common/xbps-src/shutils/common.sh
@@ -5,7 +5,7 @@ run_func() {

    : ${funcname:=$func}

-    logpipe=$(mktemp -u -p ${XBPS_STATEDIR} ${pkgname}_${XBPS_CROSS_BUILD}_XXXXXXXX.logpipe || exit 1)
+    logpipe=$(mktemp -u -p ${XBPS_STATEDIR} ${pkgname}_${XBPS_CROSS_BUILD}_XXXXXXXX.logpipe) || exit 1
    logfile=${XBPS_STATEDIR}/${pkgname}_${XBPS_CROSS_BUILD}_${funcname}.log

    msg_normal "${pkgver:-xbps-src}: running ${desc:-${func}} ...\n"